Rename shield image names based on structured route properties #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
openmaptiles
|
Now that openmaptiles/openmaptiles#1620 has been merged, this PR can proceed. We'll hold off on the final merge until the tiles are updated. Alternately, if the tiles are updated before the PR is ready, I think that means this PR will become a critical fix for Americana as well as other downstream styles such as AARoads or Gnome? |
|
GNOME Maps doesn’t use Americana tiles, but Overpass Ultra does. |
1ec5
force-pushed
the
1ec5-structured-image-names-1620
branch
from
20cc5ce to
b641f58
Compare
|
We should be able to use: As the current live-updating bleeding-edge planet. Also we should get all existing shield clients to make this change and switch to that endpoint. That should allow for a clean transition. Inspect link here: |
The name of each shield image in the style is now based on structured route properties and can includes the route name and color.
1ec5
force-pushed
the
1ec5-structured-image-names-1620
branch
from
a9841d5 to
f83d0fe
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a
proof of concept forrefactor integrating openmaptiles/openmaptiles#1620, which restructures thetransportationlayer’s feature properties to put route relation tags in structured properties instead of the inflexiblenetwork=refmini-language. This PR also plumbs route names (as opposed to road names) and route colors through to the shield selection code, though support for route colors will require an additional change to the shield library not included here.