Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer ferry styling #775

Merged
merged 9 commits into from
Feb 17, 2023
Merged

Nicer ferry styling #775

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
158e854
Make ferry routes thinner and non-dashed at low and middle zooms
quincylvania Feb 8, 2023
cb6cf80
Merge branch 'main' into nicer-ferries
quincylvania Feb 12, 2023
df9d983
Merge branch 'main' into nicer-ferries
quincylvania Feb 13, 2023
98f10d4
Switch ferry to dashed line at lower zoom level
quincylvania Feb 13, 2023
46e1c18
Merge branch 'main' into nicer-ferries
quincylvania Feb 15, 2023
3af3094
Transport-colored (violet) ferries
quincylvania Feb 15, 2023
9b44a57
Lighten ferry color somewhat
quincylvania Feb 15, 2023
7d5be9f
Blue ferries, consistently dashed
quincylvania Feb 15, 2023
91ddb81
Literally no need for `literal`
quincylvania Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/layer/ferry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,24 @@ import * as Color from "../constants/color.js";
// Filter properties in this layer should be updated to reflect consensus once
// https://github.com/openmaptiles/openmaptiles/issues/1373 is closed

//Exponent base for inter-zoom interpolation
const ferryExp = 1.2; // same as for roads

export const ferry = {
id: "ferry",
type: "line",
paint: {
"line-color": Color.waterLineBold,
"line-dasharray": [7, 5],
"line-width": 1.5,
"line-width": [
"interpolate",
["exponential", ferryExp],
["zoom"],
4,
0.55, // make slightlier thicker than roads at this scale since ferry colors are lower contrast
12,
1,
],
},
filter: [
"any",
Expand All @@ -27,7 +38,7 @@ export const ferry = {

export const legendEntries = [
{
description: "Ferry line",
description: "Ferry route",
layers: [ferry.id],
},
];