fix opened event

osmosis-labs · Nov 4, 2024 · 9822d07 · 9822d07
1 parent 22078b5
commit 9822d07
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/packages/web/modals/variants-conversion.tsx b/packages/web/modals/variants-conversion.tsx
@@ -16,7 +16,6 @@ import { EventName } from "~/config";
 import {
   useAmplitudeAnalytics,
   useAssetVariantsToast,
-  useLocalStorageState,
   useTranslation,
   useWindowSize,
 } from "~/hooks";
@@ -25,8 +24,6 @@ import { ModalBase } from "~/modals";
 import { useStore } from "~/stores";
 import { api } from "~/utils/trpc";
 
-export const CONVERT_VARIANT_MODAL_SEEN = "convert-variant-modal-seen";
-
 export const useAssetVariantsModalStore = create<{
   isOpen: boolean;
   variantCoinMinimalDenom?: string;
@@ -48,11 +45,6 @@ export const AssetVariantsConversionModal = observer(() => {
     useAssetVariantsModalStore();
   useAssetVariantsToast();
 
-  const [, setIsShown] = useLocalStorageState(
-    CONVERT_VARIANT_MODAL_SEEN,
-    false
-  );
-
   const { accountStore } = useStore();
   const account = accountStore.getWallet(accountStore.osmosisChainId);
   const { isMobile } = useWindowSize();
@@ -86,16 +78,19 @@ export const AssetVariantsConversionModal = observer(() => {
     }
   );
 
-  // should close toast if screen size changes to mobile while shown
+  // Log when opened
   useEffect(() => {
     if (isOpen) {
-      setIsShown(true);
       logEvent([EventName.ConvertVariants.startFlow]);
     }
+  }, [isOpen, logEvent]);
+
+  // should close toast if screen size changes to mobile while shown
+  useEffect(() => {
     if (isMobile && isOpen) {
       setIsOpen(false);
     }
-  }, [isOpen, isMobile, setIsOpen, setIsShown, logEvent]);
+  }, [isOpen, isMobile, setIsOpen]);
 
   return (
     <ModalBase