Publish Stage #3932
Merged
Publish Stage #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonator
commented
Nov 5, 2024
jonator
commented
- Variants conversion flow (Variants conversion flow #3931)
* feat(asset-variants-conversion-modal): updates to styles * refactor(getAllocation): refactor to handle returning Asset for matching asset / canonical asset * feat(conversion-table): clean up table row * feat(conversion-checkboxes): make all checkboxes checked by default * feat(isAlloyed-tooltip): add logic / tooltip for alloyed assets * style(loader): add loader * style(i18n): translate values * test(allocation-tests): update allocation tests * style(alloyed-assets-conversion): clean up * feat(open-asset-conversion-modal): open modal from the toast or from the convert button clicks * feat(mobile-asset-variants): handle mobile (close toast and modal) * style(convert-asset-variants): clean up * fix(width-of-asset-container): set min max width * feat(routeTokensOutGivenIn): extract functionality and add extra method for a batch * fix(variant-conversions): clean up * fix(tokenInAmount): truncate dec * feat(asset-conversion): rows demo for individual asset conversion * feat(swaps): map to network fee * docs(row-swaps): moving back to multi-swap in other branch * silence remote patterns warning * invalidate portfolio query on tx * mobile, prevent animation, format date on chart hover * improve mobile table * less padding around table * adjust * cursor * TS file * hydration error * fix feature flags & duplicate popups * move to modal folder * fix table header * layout & display fees * display fee * rename, fix imports, clean up * fix font size & variant tx loading * improve table row UI, link to swap page * Fixes FE-1075 * unify * fix server tests * extract convert logic, add amplitude events * fix localizations * cleanup log * make it possible to specify variant in modal * fix opened event * close modal after conversion * improve fee text * coderabbitai review * add learn more link * keep modal open when converting * simulate swap, add error message, log unavailable event * upper bound fee $ calculation * typo * fixed locator * @JoseRFelix review * comment --------- Co-authored-by: Matt Upham <[email protected]> Co-authored-by: yurydubinin <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoseRFelix
approved these changes
Nov 5, 2024
MaxMillington
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.