Skip to content

Commit

Permalink
upgrade TLS option and s3 module now using AI - can remove the lifecy…
Browse files Browse the repository at this point in the history
…cle rule
  • Loading branch information
jjcallis committed Aug 18, 2022
1 parent 68db87b commit 948b800
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
2 changes: 1 addition & 1 deletion aws_cloudfront_distribution.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resource "aws_cloudfront_distribution" "s3_distribution" {
cloudfront_default_certificate = var.use_cloudfront_default_certificate
acm_certificate_arn = aws_acm_certificate.certificate.arn
ssl_support_method = "sni-only"
minimum_protocol_version = "TLSv1.2_2018"
minimum_protocol_version = "TLSv1.2_2021"
}

custom_error_response {
Expand Down
19 changes: 0 additions & 19 deletions module_s3_bucket_cloudfront_logging.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
module "bucket_cloudwatch_logs_backup" {
source = "git::ssh://[email protected]/osodevops/aws-terraform-module-s3.git"
// source = "../../aws-terraform-module-s3"
s3_bucket_name = local.logging_bucket_name
s3_bucket_force_destroy = false
s3_bucket_policy = ""
Expand All @@ -16,22 +15,4 @@ module "bucket_cloudwatch_logs_backup" {
enabled = false
mfa_delete = false
}

lifecycle_rule = [
{
enabled = true
id = "retire logs after 31 days"
prefix = "logs/access"
expiration = [
{
days = 31
},
]
noncurrent_version_expiration = [
{
days = 7
},
]
}
]
}

0 comments on commit 948b800

Please sign in to comment.