Do not install rustc via rosdep #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
| run: | | ||
| apt update && apt install -y git curl libclang-dev | ||
| - name: Setup Rust for nexus_zenoh_bridge | ||
| uses: dtolnay/[email protected] |
There was a problem hiding this comment.
Any particular reason for fixing 1.71? Otherwise we can do @stable, since the curl command in the README would indeed install the latest stable by default.
This wouldn't usually matter much but rustfmt behavior changed a fair bit between 1.71 and 1.72, so CI might behave differently from local checks
There was a problem hiding this comment.
Thanks for the heads up. I'll change this to @stable
Signed-off-by: Yadunund <[email protected]>
luca-della-vedova
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nexus_zenoh_bridgepackage currently listscargoas its dependency which will installrustc v1.66.1which is the version installable via apt in Ubuntu 22.04 and most platforms. However, we would like to use the latestrustc 1.71to build other cargo crates in the system.