Skip to content

Commit

Permalink
Update detection to check specifically for installation status not ju…
Browse files Browse the repository at this point in the history
…st presence in the database.

This was providing a false positive if the package was in the apt-cache but in 'uninstalled' state, and on the other side a false negative if the package wasn't in the cache.
  • Loading branch information
tfoote committed Jan 24, 2025
1 parent b715ae5 commit a6ee824
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/rocker/templates/rmw_snippet.Dockerfile.em
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
@[ if rmw ]@
RUN \
if [ -z "${ROS_DISTRO}" ]; then echo "ROS_DISTRO is unset cannot override RMW" ; exit 1 ; fi ;\
if dpkg -l @(' '.join(packages)) > /dev/null 2>&1; then \
if ! dpkg -l @(' '.join(packages)) | grep -q ^ii ; then \
apt-get update \
&& DEBIAN_FRONTENT=non-interactive apt-get install -qy --no-install-recommends\
@(' '.join(packages)) \
Expand Down

0 comments on commit a6ee824

Please sign in to comment.