Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable competition bridges when world uses absolute paths #688

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

M1chaelM
Copy link
Collaborator

A simple fix to address problems with task-specific bridges failing, described in #680 and osrf/vrx-docker#60

To test

First observe that task specific bridges are currently failing if the competition world is specified using an absolute path:

cd vrx_ws
cp src/vrx/vrx_gz/worlds/2023_practice/practice_2023_stationkeeping0_task.sdf stationkeeping0.sdf
ros2 launch vrx_gz competition.launch.py world:=`pwd`/stationkeeping0

Note that gz topic -l shows

/vrx/stationkeeping/goal
/vrx/stationkeeping/mean_pose_error
/vrx/stationkeeping/pose_error

but ros2 topic list does not.

Now checkout this branch, build again, and re-run the launch command above. Verify that the competition topics now show up.

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as expected.

@M1chaelM M1chaelM merged commit dc3d955 into main Jun 27, 2023
@M1chaelM M1chaelM deleted the M1chaelM/abs_paths_bridges branch June 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants