Don't create issues for dangerous workflows when we have an inconclus… #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive result Signed-off-by: Colm O hEigeartaigh <[email protected]>
|
FAO @jeffmendoza |
jeffmendoza
approved these changes
Jan 8, 2024
|
Do you think this is a bug in Scorecard, or just a new result that we were not processing correctly here in this Allstar policy? |
|
I don't think it's a bug in scorecard, we just weren't properly checking for an inconclusive result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ive result
Since the recent update we are getting a ton of issues created for dangerous workflows, when the repo in question don't contain any github action workflows. The PR changes the check to pass if we have an inconclusive result (no workflows found)