-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wasm remote 2 #1288
Open
Toine-ddt
wants to merge
20
commits into
ossia:master
Choose a base branch
from
Toine-ddt:feature/wasm-remote2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/wasm remote 2 #1288
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
74023d8
add httpserver to the remote cotrol
thibaudk c035986
try to add a thread for the web socket connection
Toine-ddt e2d4b35
Update .gitignore
Toine-ddt e6028a2
Do not block score with the http server for the remotecontrol
jcelerier b9f71f6
rm some useless include
Toine-ddt de1831f
modify some variable and path
Toine-ddt c43b2aa
clean code
Toine-ddt 2304b1a
get ip address and set in remote.html
Toine-ddt 703d9b7
add comments and clean code
Toine-ddt ed8d1aa
detect ip address which start with 172.
Toine-ddt 0d54c99
detect ip address with socket / set keep_alive = false
Toine-ddt 49bb138
clean code
Toine-ddt c231ef0
add qml-remote submodule
thibaudk 0fd3ef5
changes from the review
Toine-ddt c8b914c
changes from the review
Toine-ddt 819619e
load remote.html, read and write ip address
Toine-ddt 48f0036
Update CMakeLists.txt
Toine-ddt be79bdb
Update ApplicationPlugin.cpp
Toine-ddt b1914f3
Update ApplicationPlugin.hpp
Toine-ddt ab4893e
clean code
Toine-ddt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
*.zip | ||
build-* | ||
AppRun* | ||
*.AppImage | ||
*.txz | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule qml-remote
added at
e4427b
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/plugins/score-plugin-remotecontrol/RemoteControl/ApplicationPlugin.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,17 @@ | ||
#pragma once | ||
#include <score/plugins/application/GUIApplicationPlugin.hpp> | ||
|
||
#include <RemoteControl/HttpServer.hpp> | ||
namespace RemoteControl | ||
{ | ||
class ApplicationPlugin final : public score::GUIApplicationPlugin | ||
{ | ||
public: | ||
ApplicationPlugin(const score::GUIApplicationContext& app); | ||
~ApplicationPlugin(); | ||
|
||
protected: | ||
void on_createdDocument(score::Document& doc) override; | ||
HttpServer m_server; | ||
}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... what is happening here ?