This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
container: Move more metadata into ExportOpts
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops two extra arguments we added over time; in a few places before we had e.g. `None, None, None` being passed which just looks awkward. And we also threaded through all 3 in various places. The `ExportOpts` just needs to grow a lifetime argument, but that turned out to not be too bad when I realized we could use the elided lifetime `<'_>` in all methods that use it.
cgwalters
force-pushed
the
container-export-opts
branch
from
2782f55 to
f1713aa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container: Move more metadata into
ExportOptsThis drops two extra arguments we added over time; in
a few places before we had e.g.
None, None, Nonebeing passedwhich just looks awkward. And we also threaded through all 3
in various places.
The
ExportOptsjust needs to grow a lifetime argument, but thatturned out to not be too bad when I realized we could use the
elided lifetime
<'_>in all methods that use it.container: Make
ExportOpts#[non_exhaustive]It's intended for this purpose, where we want to be able
to add elements to the struct over time without breaking semver.