Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added in new ROR search to funding body #2690

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Added in new ROR search to funding body #2690

wants to merge 15 commits into from

Conversation

lamtu1
Copy link
Contributor

@lamtu1 lamtu1 commented Sep 26, 2024 •
edited
Loading

FEATURE: Add in an autocomplete search function to the new ROR search based into the funding_body.

PROGRESS:
Part 1: Display

  • Add in the new funding_body view
  • Update the JS script for autocomplete w/ funding_body
  • Create a new QA search for ROR

Part 2: CV

  • Create the control vocab for ROR
  • Update the fetch method to make the RDF::Graph & RDF::Statement
  • Be able to save onto curation_concern
  • Index the value
  • Display in work edit page

Part 3: Test

  • Make sure it holds value
  • Make sure it display on show page
  • Make sure it display in search on SA
  • Make sure the facet is not an URI but with label
  • Create spec if needed

@lamtu1 lamtu1 self-assigned this Sep 26, 2024
@lamtu1 lamtu1 marked this pull request as draft September 26, 2024 22:26
@lamtu1
Copy link
Contributor Author

lamtu1 commented Sep 26, 2024

fixes #2604

@lamtu1 lamtu1 marked this pull request as ready for review November 20, 2024 20:44
@lamtu1 lamtu1 marked this pull request as draft November 20, 2024 20:45
@lamtu1
Copy link
Contributor Author

lamtu1 commented Nov 20, 2024

IMAGE: Screenshot of showing the progress of the new Vocab

Screenshot 2024-11-20 at 12 46 05 PM Screenshot 2024-11-20 at 12 46 37 PM

@lamtu1 lamtu1 marked this pull request as ready for review November 22, 2024 19:07
straleyb
straleyb reviewed Dec 2, 2024
View reviewed changes
app/controllers/concerns/scholars_archive/works_controller_behavior.rb
@@ -74,6 +76,35 @@ def destroy_all_files

private

# METHOD: Manually add controlled_vocab object to funding body
def store_funding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but maybe we meet up and think up a neat solution about how we could do this differently.

straleyb
straleyb reviewed Dec 2, 2024
View reviewed changes
lib/scholars_archive/controlled_vocabularies/research_organization_registry.rb

# METHOD: Add in a manual fetch for graph
# rubocop:disable Security/Open
def fetch_graph_manual
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can talk about this stuff too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straleyb straleyb straleyb left review comments

Assignees

@lamtu1 lamtu1

Labels
Enhancement Priority: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamtu1 @straleyb