Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user specified annotation for service name resolution override #111

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented Aug 22, 2023

Description

Following otterize/network-mapper#128 , adding support for user-specified annotation for service name override. The default will be intents.otterize.com/service-name as it used to be, and it will be configurable through the global value: global.serviceNameOverrideAnnotationName.

References

otterize/network-mapper#128

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@omris94 omris94 requested review from evyatarmeged and removed request for orishoshan August 24, 2023 14:28
@omris94 omris94 merged commit 62e3433 into main Aug 24, 2023
2 checks passed
@omris94 omris94 deleted the omris/support-user-specified-annotation-for-servicename branch August 24, 2023 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants