Support user specified annotation for service name override #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orishoshan
reviewed
Aug 23, 2023
omris94
requested review from
evyatarmeged and
orishoshan
and removed request for
orishoshan
evyatarmeged
approved these changes
Aug 23, 2023
omris94
deleted the
omris/support-user-specified-annotation-for-servicename
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following otterize/network-mapper#128 , adding support for user-specified annotation for service name override. The default will be
intents.otterize.com/service-nameas it used to be, and it will be configurable through the environment variable:OTTERIZE_SERVICE_NAME_OVERRIDE_ANNOTATION.After this PR we should update
go.modfor credentials-operator and network-mapper, And then expose the new env var as an helm chart value.References
otterize/network-mapper#128
Testing
Checklist