Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx bug where hostNetwork pods could be falsely detected as incoming traffic from outside of the cluster; Support resolution of LoadBalancer typed services using their node ports #240

Merged
merged 4 commits into from
Sep 19, 2024
Merged

FIx bug where hostNetwork pods could be falsely detected as incoming traffic from outside of the cluster; Support resolution of LoadBalancer typed services using their node ports #240

merged 4 commits into from
Sep 19, 2024

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented Sep 12, 2024 •
edited
Loading

Description

FIx bug where hostNetwork pods could be falsely detected as incoming traffic from outside the cluster:

  • It was done by adding an index for pod Ips that includes host network pods.
  • Added a test

Support resolution of LoadBalancer typed services using their node ports

  • Added load balancer services to the "node ports index" that used to ignore them.
  • Added a test

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht self-requested a review September 17, 2024 07:57
amitlicht
amitlicht requested changes Sep 17, 2024
View reviewed changes
src/mapper/pkg/kubefinder/kubefinder.go Outdated Show resolved Hide resolved
src/mapper/pkg/kubefinder/kubefinder.go Outdated Show resolved Hide resolved
src/mapper/pkg/kubefinder/kubefinder.go Outdated Show resolved Hide resolved
src/mapper/pkg/resolvers/schema.helpers.resolvers.go Show resolved Hide resolved
src/mapper/pkg/resolvers/schema.helpers.resolvers.go Outdated Show resolved Hide resolved
src/shared/testbase/testsuitebase.go Show resolved Hide resolved
src/mapper/pkg/kubefinder/kubefinder.go Outdated Show resolved Hide resolved
@omris94 omris94 requested review from amitlicht and removed request for orishoshan September 18, 2024 14:08
@omris94 omris94 changed the title Improve detection of incoming traffic FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Improve target service resolution by port and ip so it will be able to resolve loadBalancer services by node port Sep 18, 2024
@omris94 omris94 changed the title FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Improve target service resolution by port and ip so it will be able to resolve loadBalancer services by node port FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Improve target service resolution by port and ip so it will be able to resolve loadBalancer services using their node port Sep 18, 2024
@omris94 omris94 changed the title FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Improve target service resolution by port and ip so it will be able to resolve loadBalancer services using their node port FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Support resolution of LoadBalancer typed services using their node ports Sep 18, 2024
@omris94 omris94 changed the title FIx bug where hostNetwork pods could be false detected as incoming traffic from outside of the cluster; Support resolution of LoadBalancer typed services using their node ports FIx bug where hostNetwork pods could be falsely detected as incoming traffic from outside of the cluster; Support resolution of LoadBalancer typed services using their node ports Sep 18, 2024
@omris94 omris94 merged commit c7bfa5a into main Sep 19, 2024
21 checks passed
@omris94 omris94 deleted the omris/improve-incoming-detection-loginc branch September 19, 2024 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitlicht amitlicht amitlicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omris94 @amitlicht