Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in writing output to stderr from some CLI commands, which led to inconsistent styling and use of quiet more flag #172

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

amitlicht
Copy link
Contributor

Description

Some CLI commands were using output.PrintStderr while others were using prints.PrintCliStderr, and similarly for stdout prints. This led to inconsistency in styling as well as in handling the quiet mode flag.

This PR standardizes all CLI commands to use the prints pkg, and eliminate the old-style printing.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht requested a review from orishoshan February 10, 2025 19:44
@amitlicht amitlicht requested a review from orishoshan February 11, 2025 08:56
@amitlicht amitlicht merged commit 65ed704 into main Feb 16, 2025
7 checks passed
@amitlicht amitlicht deleted the amitlicht/outputs_via_prints branch February 16, 2025 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants