AO3-6893 Upgrade gems and configs to Rails 7.1.x #1685
Annotations
2 errors and 10 warnings
rubocop
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
rubocop
Process completed with exit code 1.
|
rubocop:
app/models/story_parser.rb#L557
[rubocop] reported by reviewdog 🐶
Avoid using `rescue` in its modifier form.
Raw Output:
app/models/story_parser.rb:557:12: C: Style/RescueModifier: Avoid using `rescue` in its modifier form.
|
rubocop:
db/migrate/20250129101815_add_service_name_to_active_storage_blobs.active_storage.rb#L6
[rubocop] reported by reviewdog 🐶
Use a guard clause (`return if column_exists?(:active_storage_blobs, :service_name)`) instead of wrapping the code inside a conditional expression.
Raw Output:
db/migrate/20250129101815_add_service_name_to_active_storage_blobs.active_storage.rb:6:5: C: Style/GuardClause: Use a guard clause (`return if column_exists?(:active_storage_blobs, :service_name)`) instead of wrapping the code inside a conditional expression.
|
rubocop:
db/migrate/20250129101815_add_service_name_to_active_storage_blobs.active_storage.rb#L9
[rubocop] reported by reviewdog 🐶
Use `==` if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Raw Output:
db/migrate/20250129101815_add_service_name_to_active_storage_blobs.active_storage.rb:9:29: W: Lint/AssignmentInCondition: Use `==` if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L7
[rubocop] reported by reviewdog 🐶
Add timestamps when creating a new table.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:7:5: C: Rails/CreateTableWithTimestamps: Add timestamps when creating a new table.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L11
[rubocop] reported by reviewdog 🐶
Do not use spaces inside percent literal delimiters.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:11:18: C: Layout/SpaceInsidePercentLiteralDelimiters: Do not use spaces inside percent literal delimiters.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L11
[rubocop] reported by reviewdog 🐶
Do not use spaces inside percent literal delimiters.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:11:43: C: Layout/SpaceInsidePercentLiteralDelimiters: Do not use spaces inside percent literal delimiters.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L16
[rubocop] reported by reviewdog 🐶
Keep a blank line before and after `private`.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:16:3: C: Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after `private`.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L17
[rubocop] reported by reviewdog 🐶
Use 2 (not 4) spaces for indentation.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:17:1: C: Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L17
[rubocop] reported by reviewdog 🐶
Inconsistent indentation detected.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:17:5: C: Layout/IndentationConsistency: Inconsistent indentation detected.
|
rubocop:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb#L22
[rubocop] reported by reviewdog 🐶
Use 2 (not 4) spaces for indentation.
Raw Output:
db/migrate/20250129101816_create_active_storage_variant_records.active_storage.rb:22:1: C: Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
|
Loading