AO3-3471 Filter works per language on language_works_path (#4659)

* Use ElasticSearch to filter works per language

https://otwarchive.atlassian.net/browse/AO3-3471

* Display which language

At least once outside the url

* Syntax

* Replace languages#show with a redirect

* Cop

* Update tests to new behavior

* Alt route syntax

* Revert "Alt route syntax"

This reverts commit 3af690d.

app/controllers/languages_controller.rb

@@ -4,11 +4,6 @@ def index
     @languages = Language.default_order
   end
 
-  def show
-    @language = Language.find_by(short: params[:id])
-    @works = @language.works.recent.visible.limit(ArchiveConfig.NUMBER_OF_ITEMS_VISIBLE_IN_DASHBOARD)
-  end
-
   def new
     @language = Language.new
     authorize @language
@@ -35,7 +30,7 @@ def update
     authorize @language
     if @language.update(language_params)
       flash[:notice] = t('successfully_updated', default: 'Language was successfully updated.')
-      redirect_to @language
+      redirect_to languages_path
     else
       render action: "new"
     end

app/controllers/works_controller.rb

@@ -771,7 +771,8 @@ def load_owner
         end
       end
     end
-    @owner = @pseud || @user || @collection || @tag
+    @language = Language.find_by(short: params[:language_id]) if params[:language_id].present?
+    @owner = @pseud || @user || @collection || @tag || @language
   end
 
   def load_work

app/helpers/search_helper.rb

@@ -25,6 +25,8 @@ def search_header(collection, search, item_name, parent=nil)
       header << ts("by %{byline}", byline: parent.byline)
     when User
       header << ts("by %{username}", username: parent.login)
+    when Language
+      header << ts("in %{language}", language: parent.name)
     end
 
     header << ts("in %{tag_link}", tag_link: link_to_tag_with_text(parent, parent.name)) if parent.is_a?(Tag)

app/models/language.rb

@@ -1,4 +1,5 @@
 class Language < ApplicationRecord
+  include WorksOwner
   validates_presence_of :short
   validates :short, uniqueness: true
   validates_presence_of :name

app/models/search/work_query.rb

@@ -44,6 +44,12 @@ def queries
 
   def add_owner
     owner = options[:works_parent]
+
+    if owner.is_a?(Language)
+      options[:language_id] = owner.short
+      return
+    end
+
     field = case owner
             when Tag
               :filter_ids

config/routes.rb

@@ -510,10 +510,11 @@
   #### I18N ####
 
   # should stay below the main works mapping
-  resources :languages do
+  resources :languages, except: [:show] do
     resources :works
     resources :admin_posts
   end
+  get "/languages/:id", to: redirect("/languages/%{id}/works", status: 302)
   resources :locales, except: :destroy
 
   #### API ####

features/other_a/languages.feature

@@ -37,9 +37,10 @@ Feature: Languages
   # Browse works in a language
 
   When I am on the languages page
+    And all indexing jobs have been run
   Then I should see "Deutsch"
   When I follow "Deutsch"
-  Then I should see "1 works in 1 fandoms"
+  Then I should see "1 Work in Deutsch"
     And I should see "Die Rache der Sith"
     And I should not see "Revenge of the Sith"
 

features/step_definitions/work_steps.rb

@@ -564,6 +564,14 @@
   step "the periodic tag count task is run"
 end
 
+When "I browse works in language {string}" do |language_name|
+  step %{all indexing jobs have been run}
+  step "the periodic tag count task is run"
+
+  language = Language.find_by(name: language_name)
+  visit language_works_path(language)
+end
+
 When /^I delete the work "([^"]*)"$/ do |work|
   work = Work.find_by(title: CGI.escapeHTML(work))
   visit edit_work_path(work)

features/works/work_browse.feature

@@ -152,3 +152,27 @@ chapter when the chapters are reordered.
   When I follow the comments link for the work "Awesome Work"
   Then I should be on the work "Awesome Work"
     And I should see "Bravo!"
+
+Scenario: Can also browse work indexed by language
+    Given basic languages
+      And Persian language
+      And basic tags
+      And I am logged in
+      And I post the work "Whatever 1" with fandom "Aggressive Retsuko"
+      And I post the work "Whatever 2" with fandom "Aggressive Retsuko"
+    When I go to the new work page
+      And I select "Not Rated" from "Rating"
+      And I check "No Archive Warnings Apply"
+      And I fill in "Fandoms" with "Weiß Kreuz"
+      And I fill in "Work Title" with "Überraschende Überraschung"
+      And I fill in "content" with "Dies ist eine Fanfic in Deutsch."
+      And I select "Deutsch" from "Choose a language"
+    When I press "Post"
+    Then I should see "Work was successfully posted."
+      And I should see "Deutsch" within "dd.language"
+    When I browse works in language "English"
+      Then I should see "2 Works in English"
+    When I browse works in language "Deutsch"
+      Then I should see "1 Work in Deutsch"
+    When I browse works in language "Persian"
+      Then I should see "0 Works in Persian"

spec/controllers/languages_controller_spec.rb

@@ -25,26 +25,6 @@
     end
   end
 
-  describe "GET show" do
-    context "when not logged in" do
-      it "renders the show template" do
-        get :show, params: { id: "en" }
-        expect(response).to render_template("show")
-      end
-    end
-
-    Admin::VALID_ROLES.each do |role|
-      context "when logged in as an admin with #{role} role" do
-        let(:admin) { create(:admin, roles: [role]) }
-
-        it "renders the show template" do
-          get :show, params: { id: "en" }
-          expect(response).to render_template("show")
-        end
-      end
-    end
-  end
-
   describe "GET new" do
     context "when not logged in" do
       it "redirects with error" do
@@ -227,7 +207,7 @@
         end
 
         it "redirects and returns success message" do
-          it_redirects_to_with_notice(finnish, "Language was successfully updated.")
+          it_redirects_to_with_notice(languages_path, "Language was successfully updated.")
         end
       end
     end