AO3-6820: add presence validation to belongs_to instead

otwcode · Feb 1, 2025 · 4655053 · 4655053
1 parent 97fa3e6
commit 4655053
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/models/bookmark.rb b/app/models/bookmark.rb
@@ -5,8 +5,7 @@ class Bookmark < ApplicationRecord
   include Taggable
 
   belongs_to :bookmarkable, polymorphic: true, inverse_of: :bookmarks
-  belongs_to :pseud
-  validates :pseud_id, presence: true
+  belongs_to :pseud, optional: false
 
   validates_length_of :bookmarker_notes,
     maximum: ArchiveConfig.NOTES_MAX, too_long: ts("must be less than %{max} letters long.", max: ArchiveConfig.NOTES_MAX)

diff --git a/spec/models/bookmark_spec.rb b/spec/models/bookmark_spec.rb
@@ -18,6 +18,6 @@
   it "is invalid without a pseud_id" do
     bookmark = build(:bookmark, pseud_id: nil)
     expect(bookmark).to_not be_valid
-    expect(bookmark.errors[:pseud_id].first).to include("can't be blank")
+    expect(bookmark.errors[:pseud].first).to include("must exist")
   end
 end