Apply suggestions from code review

Co-authored-by: Brian Austin <[email protected]>
otwcode · Jan 16, 2025 · 984445e · 984445e
1 parent 277ed88
commit 984445e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/app/models/pseud.rb b/app/models/pseud.rb
@@ -454,6 +454,6 @@ def reindex_creations
   end
 
   def reindex_user
-    user.enqueue_to_index
+    after_commit { user.enqueue_to_index }
   end
 end
diff --git a/config/locales/views/en.yml b/config/locales/views/en.yml
@@ -166,11 +166,11 @@ en:
           no_invitation: Created without invitation
           no_role: No roles
           past_emails:
-            one: 'Past Email:'
-            other: 'Past Emails:'
+            one: 'Past email:'
+            other: 'Past emails:'
           past_logins:
-            one: 'Past Username:'
-            other: 'Past Usernames:'
+            one: 'Past username:'
+            other: 'Past usernames:'
           role:
             one: 'Role:'
             other: 'Roles:'

diff --git a/features/admins/users/admin_find_users.feature b/features/admins/users/admin_find_users.feature
@@ -18,7 +18,7 @@ Feature: Admin Find Users page
       And I should see "userB"
       And I should see "userCB"
 
-  Scenario: The Find Users page performs a exact match on name by default
+  Scenario: The Find Users page performs an exact match on name by default
     When I fill in "Name" with "user"
       And I submit
     Then I should see "0 users found"
@@ -51,7 +51,7 @@ Feature: Admin Find Users page
       And I should see "userCB"
       But I should not see "userA"
 
-  Scenario: The Find Users page performs a exact match on email by default
+  Scenario: The Find Users page performs an exact match on email by default
     When I fill in "Email" with "ao3"
       And I submit
     Then I should see "0 users found"