-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6548 Add "(Guest)" to guest comments #4596
Conversation
app/views/comment_mailer/edited_comment_reply_notification.html.erb
Outdated
Show resolved
Hide resolved
app/views/comment_mailer/edited_comment_reply_notification.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment/question from me! (Also, if you do change things would you mind getting the Reviewdog warnings too? No worries on those either way though 😄 )
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6548
Purpose
Add "(Guest)" to guest names in guest comments in the web UI and in emails
Testing Instructions
See JIRA ticket
Credit
EchoEkhi (he/him)