Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6636 Move next chapter prefetch outside cache block #4668

Closed
wants to merge 1 commit into from

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Nov 21, 2023

This should ensure it shows up on all chapters, including ones that have been cached recently.

This is a speculative fix and should be reviewed by someone who understands the caching mechanisms better than me, before merging. I creating this PR to make it easy to merge, in case this is the right fix.

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6636

Purpose

Ensure speculation rules next chapter prefetching is not part of the cached content for a work, and thus shows up on all chapters.

Testing Instructions

General testing instructions for the feature are on the issue, but for this caching issue specifically, @sarken suggests testing on works which had previously been generated this change, maybe?

References

This comment https://otwarchive.atlassian.net/browse/AO3-6636?focusedCommentId=360659

Credit

Domenic Denicola, he/him

This should ensure it shows up on all chapters, including ones that have been cached recently.
@brianjaustin brianjaustin added the Priority: High - Broken on Test Merge immediately after approval label Nov 21, 2023
@domenic domenic mentioned this pull request Nov 22, 2023
5 tasks
@sarken
Copy link
Collaborator

sarken commented Nov 22, 2023

Closing because we went with #4670 -- thanks!

@sarken sarken closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants