AO3-6636 Move next chapter prefetch outside cache block #4668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure it shows up on all chapters, including ones that have been cached recently.
This is a speculative fix and should be reviewed by someone who understands the caching mechanisms better than me, before merging. I creating this PR to make it easy to merge, in case this is the right fix.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6636
Purpose
Ensure speculation rules next chapter prefetching is not part of the cached content for a work, and thus shows up on all chapters.
Testing Instructions
General testing instructions for the feature are on the issue, but for this caching issue specifically, @sarken suggests testing on works which had previously been generated this change, maybe?
References
This comment https://otwarchive.atlassian.net/browse/AO3-6636?focusedCommentId=360659
Credit
Domenic Denicola, he/him