-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-5937 "Save" button visible on bookmarks when logged out and on a tag's bookmarks page #4757
base: master
Are you sure you want to change the base?
Conversation
Could you add an integration test covering this fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should help with the ERB lint warning (I have not had a chance to test locally though, so some further nudges may be required)
Co-authored-by: Brian Austin <[email protected]>
Co-authored-by: Brian Austin <[email protected]>
I'm writing the integration test for this now (or at least, trying to), and I've noticed that the |
Hi! I have no fucking idea what RuboCop wants from me. I've tried a ton of different indents and it is still upset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If rubocop and/or erblint is giving me trouble, I usually will run
rubocop -A path/to/file.rb
# or
erblint -A path/to/file.html.erb
That will often do a lot more than we need, so I also use git add -p
to selectively add lines to my commit, and then run git checkout path/to/file.rb
to avoid changing a bunch of things at once. I sympathise with fighting erblint/rubocop though, so I've pushed what ERB lint seems to want to brianjaustin@6f6f854
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-5937
Purpose
Wraps the "save" and "saved" actions for bookmarks in a
logged_in?
check.Testing Instructions
I have left a comment for clarification on the JIRA ticket.
Credit
calm (they/them)