Don't use autonat or relay if relay server is enabled #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
ligustah
force-pushed
the
logging-improvements
branch
from
a308830 to
470c84a
Compare
ligustah
force-pushed
the
disable-autonat-with-external-address-set
branch
from
ddfd544 to
76b200f
Compare
erikreppel
approved these changes
May 3, 2024
ligustah
force-pushed
the
logging-improvements
branch
from
470c84a to
5fe9b69
Compare
ligustah
force-pushed
the
disable-autonat-with-external-address-set
branch
from
76b200f to
f8d6b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autonat is sometimes causing issues for our server nodes. If we know that we have an externally reachable address, we shouldn't rely on autonat to confirm it.
The way the implementation works autonat will always only try to connect to addresses that it can observe from the connecting node, which means it might not confirm the supposed external address of the server node.