Reserve Auction Listing w/ Adjustable Buffer and Increment #184
+1,317
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgeary
force-pushed
the
james/configurable-buffer-and-increment-auctions
branch
from
eb6d215
to
1a9cc07
Compare
jgeary
force-pushed
the
james/configurable-buffer-and-increment-auctions
branch
from
1a9cc07
to
dfe4591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve Auction Listing Adjustable Buffer Increment
Description
Allow users to create auctions with their own parameters for time buffer and minimum percent increment. This will be our last variation of reserve auctions before auditing and deploying the omnibus - this module is a slight modification of ReserveAuctionListingEth which introduces no new security concerns, so should not need a new audit. This module will be used by a well-known DAO in the space soon, so it is ideal that they are not held up by the omnibus audit. I will also have to update the omnibus to include this functionality.
Reserve Auctions Listing Fee ETH with two added parameters - time buffer and min percent increment. They work the same as the hardcoded defaults in our other reserve auction modules, and those defaults still exist here if you pass in 0s for these parameters.