Install Uapi/shield crate to staging #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fvalette-ledger
commented
Dec 6, 2024
•
fvalette-ledger
commented
- create local registry at startup
- remove nigthly cargo
- install uapi
- install shield
- install deps (kconfig, metadata)
- install task
- relink task
returns true if cargo index lock file exists.
fvalette-ledger
added
build-system
Allow to capture stdout as text while executing command.
remove --out-dir option Add OUT_DIR variable. /!\ /!\ UBER WARNING /!\ /!\ Those arn't related at all even of they are named the same ... OUT_DIR is for build script output dir --out-dir an experimental feature that allow user to override the output dir for crate build (renamed artifact-dir but still a nightly feature).
at setup, deploy a new cargo local registry if required and install kernel crates.
Using the built-in decorator, can be used either as context manager (with statement) or decorator. > Note that this feature is added to contextlib since python 3.11. Our minimal python requirement is 3.10...
Blake and flake8 will check for W504 rule which is incompatible with W503 rule. **BUT** Flake8 will check both by default which leads to impossible compliance in case of line too long (impossible split where operator at the end and the beginning are forbiden at the same time).
Cargo index will silently change directory to cargo manifest root dir. This breaks the cargo config path resolver and barbican local registry is not "parsed" by cargo and packaging may fail. Instead, call cargo package and then, push the crate w/ cargo index instead of manifest use for cargo index add.
pthierry-ledger
approved these changes
Dec 13, 2024
--force option does not seem to have any effect while used with `--crate` instead of `--manifest-path`. So, forge index entry based on crate name, i.e. 'index/<2 first letters>/<2 next letters>/<name>' and remove index entry.
pthierry-ledger
approved these changes
Dec 17, 2024
fvalette-ledger
force-pushed
the
install-outpost-crates
branch
from
9065430 to
e3a1491
Compare
fvalette-ledger
force-pushed
the
install-outpost-crates
branch
from
e3a1491 to
c1d3a9f
Compare
use the kernel metadata to retreive linker and objcopy to use in case of non introspectable package (i.e. non Meson). TODO: may be every package should use kernel metadata for thus purpose as all meson package are built with the same cross-file.
cargo build binary w/o extension but inner build system requires that elf to be integrated to firmware got this extension. This is appended by install step.
linker pass through rustflags will fail to be resolved from build script. So, we have to filter this flags out from rustflags and add a dedicated specific target entry in config.toml.
fvalette-ledger
force-pushed
the
install-outpost-crates
branch
from
83e9902 to
7d33545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.