chore: move is_docker_rootless from tutor to tutor discovery #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Faraz32123
commented
Nov 22, 2024
Faraz32123
commented
- move is_docker_rootless method from tutor to tutor-discovery
- move is_docker_rootless related tests from tutor to tutor-discovery and modify makefile according to it.
regisb
reviewed
Nov 22, 2024
tutordiscovery/plugin.py
Outdated
| @@ -95,7 +96,7 @@ | |||
|
|
|||
|
|
|||
| # Automount /openedx/discovery folder from the container | |||
| @tutor_hooks.Filters.COMPOSE_MOUNTS.add() | |||
| @tutor_hooks.Filters.COMPOSE_MOUNTS.add() # type: ignore | |||
There was a problem hiding this comment.
Nope, let's not type-ignore this (same below).
There was a problem hiding this comment.
actually this was needed to run pylint checks which were failing before, is there any other proposition. Or we can just remove it?
There was a problem hiding this comment.
Your "ignore" statement is not for pylint but for mypy. Mypy checks are failing probably because tutor is installed in editable mode: overhangio/tutor#956
These tests should not fail in CI.
There was a problem hiding this comment.
ohk my bad, had to say mypy :)
If that's the case, I will remove it now.
regisb
reviewed
Nov 22, 2024
| @@ -0,0 +1,26 @@ | |||
| import subprocess | |||
There was a problem hiding this comment.
Nice job moving the unit tests here!
- move is_docker_rootless method from tutor to tutor-discovery - move is_docker_rootless related tests from tutor to tutor-discovery and modify makefile according to it.
Faraz32123
force-pushed
the
perf/move_is_docker_rootless_from_tutor_to_tutor_discovery
branch
from
ac52a96 to
bdb15ed
Compare
regisb
deleted the
perf/move_is_docker_rootless_from_tutor_to_tutor_discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.