fix: init task error

Close #59.
overhangio · Dec 11, 2023 · 9d44b89 · 9d44b89
1 parent 0198510
commit 9d44b89
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/changelog.d/20231211_115338_regis.md b/changelog.d/20231211_115338_regis.md
@@ -0,0 +1 @@
+- [Bugfix] Fix error during init task: "'tuple object' has no attribute 'name'". (by @regisb)
diff --git a/tutorecommerce/templates/ecommerce/tasks/ecommerce/init b/tutorecommerce/templates/ecommerce/tasks/ecommerce/init
@@ -1,8 +1,8 @@
 ./manage.py migrate --noinput
 ./manage.py oscar_populate_countries --initial-only
 
-{% for app in iter_mfes() %}
-{% if app["name"] == "payment" %}
+{% for app_name, app in iter_mfes() %}
+{% if app_name == "payment" %}
 ./manage.py create_or_update_site \
   --site-id=1 \
   --site-domain={{ ECOMMERCE_HOST }}:8130 \
@@ -21,7 +21,7 @@
   --payment-support-url="http://{{ LMS_HOST }}:8000/support" \
   --discovery_api_url=http://{{ DISCOVERY_HOST }}:8381/api/v1/ \
   --enable-microfrontend-for-basket-page=true \
-  --payment-microfrontend-url="http://{{ MFE_HOST }}:{{ app['port'] }}/{{ app['name'] }}"
+  --payment-microfrontend-url="http://{{ MFE_HOST }}:{{ app['port'] }}/{{ app_name }}"
 
 # Production site
 ./manage.py create_or_update_site \
@@ -43,7 +43,7 @@
   --payment-support-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}/support" \
   --discovery_api_url={% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ DISCOVERY_HOST }}/api/v1/ \
   --enable-microfrontend-for-basket-page=true \
-  --payment-microfrontend-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ MFE_HOST }}/{{ app['name'] }}"
+  --payment-microfrontend-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ MFE_HOST }}/{{ app_name }}"
 {% endif %}
 {% endfor %}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		- [Bugfix] Fix error during init task: "'tuple object' has no attribute 'name'". (by @regisb)