-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump version to 16.0.1 #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. But this should be a backward-compatible change, so the new version should be 16.0.1.
Also, please add a changelog entry in CHANGELOG.md and collect existing entries with scriv collect
.
566f966
to
51186ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All you need to do is to change the title of your commit to "v16.0.1".
51186ff
to
2d1e21a
Compare
@regisb ready, thanks for the prompt review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@regisb although the new image has been pushed, it still references an old commit https://github.com/openedx/cs_comments_service/tree/1f0f0568f001dd9a5be483702dd41c1f40453a60 Can you rebuild the image? |
I think there was a misunderstanding. The forum image will always reference the open-release/palm.2 tag, not the open-release/palm.master branch. The reason for that is that builds need to be reproducible. If you want to add extra commits to the cs_comments_service repo in the forum image, then you should either:
|
Description
This PR bumps version to support the latest changes to
cs_comment_service
: openedx/cs_comments_service@open-release/palm.2...masterMainly this PR: openedx/cs_comments_service#415