Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump version to 16.0.1 #26

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Oct 2, 2023

Description

This PR bumps version to support the latest changes to cs_comment_service: openedx/cs_comments_service@open-release/palm.2...master

Mainly this PR: openedx/cs_comments_service#415

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. But this should be a backward-compatible change, so the new version should be 16.0.1.

Also, please add a changelog entry in CHANGELOG.md and collect existing entries with scriv collect.

@regisb regisb requested a review from ghassanmas October 2, 2023 13:28
@Ian2012 Ian2012 force-pushed the cag/trigger-upgrade branch from 566f966 to 51186ff Compare October 2, 2023 14:26
@Ian2012 Ian2012 changed the title feat: bump version to 16.1.0 feat: bump version to 16.0.1 Oct 2, 2023
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All you need to do is to change the title of your commit to "v16.0.1".

@Ian2012 Ian2012 force-pushed the cag/trigger-upgrade branch from 51186ff to 2d1e21a Compare October 2, 2023 14:59
@Ian2012
Copy link
Contributor Author

Ian2012 commented Oct 2, 2023

@regisb ready, thanks for the prompt review

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@regisb regisb merged commit f9db310 into overhangio:master Oct 2, 2023
@Ian2012
Copy link
Contributor Author

Ian2012 commented Oct 3, 2023

@regisb although the new image has been pushed, it still references an old commit https://github.com/openedx/cs_comments_service/tree/1f0f0568f001dd9a5be483702dd41c1f40453a60

Can you rebuild the image?

@regisb
Copy link
Contributor

regisb commented Oct 3, 2023

I think there was a misunderstanding. The forum image will always reference the open-release/palm.2 tag, not the open-release/palm.master branch. The reason for that is that builds need to be reproducible. If you want to add extra commits to the cs_comments_service repo in the forum image, then you should either:

  1. Cherry-pick these changes, as it is being done for edx-platform in the openedx image.
  2. Wait for the open-release/palm.3 tag, which should be created very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants