Skip to content

Commit

Permalink
fix: remove trailing slash from PUBLIC_PATH env var
Browse files Browse the repository at this point in the history
We previously generated the PUBLIC_PATH base for each MFE with a
trailing slash, e.g. "/authn/". But the actual links that point to
these from the LMS and Studio don't have a trailing slash in them,
e.g. "/authn". This commit removes the trailing slash to be consistent.
  • Loading branch information
ormsbee committed Oct 3, 2023
1 parent f0aa8a5 commit 510ef94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tutormfe/templates/mfe/build/mfe/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ EXPOSE {{ app['port'] }}

# Configuration needed at build time
ENV APP_ID={{ app_name }}
ENV PUBLIC_PATH='/{{ app_name }}/'
ENV PUBLIC_PATH='/{{ app_name }}'
# We could in theory point the mfe_config API directly to the LMS. But for that we would
# have to code the LMS url into the mfe image, and this configuration is user-dependent.
# So we point to a relative url that will be a proxy for the LMS.
Expand Down

0 comments on commit 510ef94

Please sign in to comment.