Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add learner-dashbaord-dev image #191

Merged

Conversation

Danyal-Faheem
Copy link
Contributor

Fixes #188.

Added the learner-dashboard-dev image to the gitlab-ci so it can be pushed to the overhangio dockerhub repository.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to commit the .gitlab-ci.yml file :)

@Danyal-Faheem
Copy link
Contributor Author

I think you forgot to commit the .gitlab-ci.yml file :)

Whoops, sorry. I've added it now.

.gitlab-ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisb regisb merged commit d662313 into overhangio:master Feb 21, 2024
1 check passed
@regisb regisb deleted the danyalfaheem/add-learner-dashboard-dev-to-ci branch February 21, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhangio/openedx-learner-dashboard-dev, repository does not exist?
2 participants