Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master' into nightly
Browse files Browse the repository at this point in the history
  • Loading branch information
Overhang.IO committed Nov 21, 2024
2 parents ba225a1 + 8c7996c commit 541fabe
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions changelog.d/20241119_111602_fghaas_image_manifest.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- [Improvement] When building images with
`tutor images build --cache-to-registry`, use an OCI-compliant cache
artifact format that should be universally compatible with all
registries. This enables the use of that option when working with
third-party registries such as [Harbor](https://goharbor.io/) or
[ECR](https://aws.amazon.com/ecr/). Requires
[BuildKit 0.12](https://github.com/moby/buildkit/releases/tag/v0.12.0)
or later. (by @angonz and @fghaas)
2 changes: 1 addition & 1 deletion tutor/commands/images.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ def build(
image_build_args.append(f"--cache-from=type=registry,ref={tag}-cache")
if cache_to_registry:
image_build_args.append(
f"--cache-to=type=registry,mode=max,ref={tag}-cache"
f"--cache-to=type=registry,mode=max,ref={tag}-cache,image-manifest=true"
)

# Build contexts
Expand Down

0 comments on commit 541fabe

Please sign in to comment.