Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Open edX Image to Python 3.11 #1056

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented May 2, 2024

Updates Tutor Open edX dockerfile to setup Python 3.11. Some dependencies have been updated as well. Upsteam PR openedx/edx-platform#34374.

This PR is currently doing upgrade using pyenv. A followup PR that setups Python 3.11 from Python image would be merged later (#1057). It is currently being tested.

Testing Instructions

  • Checkout the branch on your local
  • Install your local tutor
  • Ensure the tutor version is nightly.
  • Run tutor config save. Verify docker file has been updated
  • Run tutor images build opened --no-cache to build a clean image. Verify the image builds as expected. Verify the PYthon inside image is 3.11
  • Start tutor and verify LMS/CMS are running

@DawoudSheraz DawoudSheraz marked this pull request as ready for review May 2, 2024 15:07
Copy link
Collaborator

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the containers now run Python 3.11, and that I was able to run LMS, CMS, and some unit tests under 3.11. Thanks @DawoudSheraz !

@@ -0,0 +1 @@
- [Feature] Upgrade Open edX Dockerfile to use Python 3.11 (by @dawoudsheraz)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest mentioning openedx image rather than the openedx Dockerfile. The reason I say this is that the Dockerfile is an implementation detail that not every Tutor user thinks about, but all Tutor users are aware of the image.

@DawoudSheraz DawoudSheraz changed the title feat: upgrade Dockerfile to Py311 feat: upgrade Open edX Image to Python 3.11 May 8, 2024
@DawoudSheraz DawoudSheraz merged commit c7b4327 into nightly May 9, 2024
2 checks passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/py311 branch May 9, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants