Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a filter to define celery workers command #1134

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Oct 8, 2024

Description

This PR implements two new similar filters to define the command for the celery workers.

@Ian2012 Ian2012 changed the title POC feat: add support for celery multiqueue feat: add support for celery multiqueue Oct 18, 2024
@Ian2012 Ian2012 marked this pull request as ready for review October 18, 2024 18:15
@jfavellar90
Copy link

@Ian2012 please change the PR title since it isn't related to a celery multi-queue implementation

@Ian2012 Ian2012 changed the title feat: add support for celery multiqueue feat: add a filter to define celery workers command Oct 21, 2024
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/plugins/openedx.py Outdated Show resolved Hide resolved
tutor/templates/local/docker-compose.prod.yml Outdated Show resolved Hide resolved
@regisb
Copy link
Contributor

regisb commented Nov 19, 2024

Please also add a changelog entry.

@Ian2012 Ian2012 force-pushed the cag/celery-queues branch 2 times, most recently from 6f8a8ac to 371fce5 Compare November 19, 2024 15:06
@Ian2012 Ian2012 requested a review from regisb November 21, 2024 21:36
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ready to merge once the docker compose command of the cms celery worker is fixed!

@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 22, 2024

Done

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@regisb regisb merged commit e6bbd25 into overhangio:master Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants