feat: migrate from setup.py/setuptools to pyproject.toml/hatch #1163
+110
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt both to modernize the packaging and to fix mypy testing in editable mode (issue #956). Packaging seems to work, but mypy testing still fails. Will now attempt to migrate from setuptools to hatch for building.
regisb
force-pushed
the
regisb/pyproject.toml
branch
from
a071906
to
73441d2
Compare
| pip install . | ||
| pip install -r requirements/dev.txt | ||
|
|
||
| bootstrap-dev-plugins: bootstrap-dev ## Install dev requirements and all supported plugins |
There was a problem hiding this comment.
Any particular reasons for merging this? I get this is being made part of full, just thinking if someone was using this in their automation and can break.
There was a problem hiding this comment.
The make are not supposed to be part of the Tutor API, so I think it's OK to make breaking changes here. The goal of this change is to get rid of an unused command.
Comment on lines
+12
to
+14
| pip-compile ${COMPILE_OPTS} requirements/base.in | ||
| pip-compile ${COMPILE_OPTS} requirements/dev.in | ||
| pip-compile ${COMPILE_OPTS} requirements/docs.in |
There was a problem hiding this comment.
What's the reason for having COMPILE_OPTS? What values can it have?
There was a problem hiding this comment.
This is a technique that I also used in edx-platform to de-duplicate the list of *.in files in the Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issue #956, I realized that the issue might be resolved if we switched from setuptools to hatch as package builder. But to achieve that, we also need to migrate from setup.py to pyproject.toml. This was a long overdue chore, as setup.py is no longer recommended (see PEP 621).
I'm not sure whether we should be merging this change now, later (or ever). I think this should be safe... So I would lean towards merging it now (and eventually migrate plugins and cookiecutter to pyproject.toml as well). But I'm curious what ya'll think @kdmccormick @DawoudSheraz.