feat: atlas pull for plugins and xblocks | FC-0012 #993
Conversation
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
plugins-xblocks
branch
from
f56b37d to
7d2bebf
Compare
|
@regisb this is now ready for review. |
OmarIthawi
force-pushed
the
plugins-xblocks
branch
from
7d2bebf to
1ce8740
Compare
OmarIthawi
force-pushed
the
plugins-xblocks
branch
2 times, most recently
from
f60eb8b to
03ddb6d
Compare
|
@regisb @DawoudSheraz this is now ready and tested on my machine. Please let me know if it breaks or you have any further questions. |
OmarIthawi
force-pushed
the
plugins-xblocks
branch
from
03ddb6d to
0b8d78b
Compare
| translations/edx-platform/conf/locale:conf/locale \ | ||
| translations/studio-frontend/src/i18n/messages:conf/plugins-locale/studio-frontend | ||
| RUN ./manage.py lms compile_xblock_translations | ||
| RUN ./manage.py cms compile_xblock_translations |
There was a problem hiding this comment.
Why not use the --settings=tutor.i18n option with the compile_xblock_translations commands? As far as I know, loading production settings just fails during build.
(I wish I could test this but I don't have great internet connection right now)
There was a problem hiding this comment.
100%. Good catch. I thought this change has already been made. Now it's done.
$ tutor images build --no-cache openedx works locally for me. We'll see if it breaks for someone else.
There was a problem hiding this comment.
Now it builds correctly:
=> [production 16/33] COPY --chown=app:app settings/lms/*.py ./lms/envs/tutor/ 0.1s
=> [production 17/33] COPY --chown=app:app settings/cms/*.py ./cms/envs/tutor/ 0.0s
=> [production 18/33] RUN ./manage.py lms --settings=tutor.i18n pull_plugin_translations --verbose --repository='openedx/openedx-translations' --revisio 6.7s
=> [production 19/33] RUN ./manage.py lms --settings=tutor.i18n pull_xblock_translations --repository='openedx/openedx-translations' --revision='main' 6.0s
=> [production 20/33] RUN atlas pull --repository='openedx/openedx-translations' --revision='main' translations/edx-platform/conf/locale:conf/local 3.7s
=> [production 21/33] RUN ./manage.py lms --settings=tutor.i18n compile_xblock_translations 4.5s
=> [production 22/33] RUN ./manage.py cms --settings=tutor.i18n compile_xblock_translations 4.7s
=> [production 23/33] RUN ./manage.py lms --settings=tutor.i18n compile_plugin_translations 4.0s
=> [production 24/33] RUN ./manage.py lms --settings=tutor.i18n compilemessages -v1 3.2s
=> [production 25/33] RUN ./manage.py lms --settings=tutor.i18n compilejsi18n 3.8s
=> [production 26/33] RUN ./manage.py cms --settings=tutor.i18n compilejsi18n
0b8d78b to
9f7b26f
Compare
OmarIthawi
force-pushed
the
plugins-xblocks
branch
from
9f7b26f to
9e8d9dc
Compare
|
@regisb @DawoudSheraz please let me know if there are more questions or concerns, otherwise this pull request is ready. |
Its already approved from my end. Once @regisb approves, it will be merged. Thanks. |
|
@regisb I hope all is good with you. Would you mind triaging this PR or let me know if there's any error that need to be addressed. |
|
@regisb A gentle reminder about this pull request. |
It's now merge! Thanks for the support Regis :) |
Pulls translations for plugins and XBlock using the newly introduced commands:
atlas pullfor XBlock translations | FC-0012 openedx/edx-platform#33698TODO
masteropenedximage file systematlas pull results
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.