Add new aliases to the sample interval, reconnect interval, and update interval attributes #1507
Conversation
|
@nick-enoent I'm not sure whether this patch affects the YAML patch or Maestro or not. |
|
Resolves #1497 |
| @@ -357,42 +357,66 @@ class LdmsdCmdParser(cmd.Cmd): | |||
| def complete_daemon_exit(self, text, line, begidx, endidx): | |||
| return self.__complete_attr_list('daemon_exit', text) | |||
|
|
|||
| def __handle_reconnect_alias(reconnect_interval, reconnect, interval): | |||
There was a problem hiding this comment.
Could we possibly move this function to ldmsd_communicator.py? I realize we don't have parser_util.py merged yet, or I'd suggest moving it there. This would be useful to be able to call when parsing YAML files for both the ldmsd -y option and maestro_ctrl
There was a problem hiding this comment.
@nick-enoent let's look at the API and decide if we need something else.
nichamon
force-pushed
the
interval-aliases
branch
from
870cd0e
to
1786789
Compare
Change the attribute name to 'reconnect_interval' for consistency with the attributes in prdcr_add, prdcr_start, and prdcr_start_regex
nichamon
force-pushed
the
interval-aliases
branch
from
1786789
to
4b53b3b
Compare
|
On Hold for Future Release (v4.5+) This PR is being postponed to a future release due to potential impacts on existing configuration file generation scripts. Impact:
We'll revisit this change after v4.4.5 to ensure a smooth transition for all users. The pull request was converted to draft until a target version is made. |
No description provided.