Rename and update Sampler Advertisement man page #1531
+34
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nichamon, these really aren't sampler advertisements...correct? They are ldmsd peer advertisements. The ldmsd peer may have no samplers at all. |
tom95858
reviewed
Nov 21, 2024
| @@ -47,7 +47,7 @@ ldmsd_sampler_advertisement - Manual for LDMSD Sampler Advertisement | |||
|
|
|||
| .SH DESCRIPTION | |||
|
|
|||
| LDMSD Sampler Discovery is a capability that enables LDMSD automatically add | |||
| LDMSD Sampler Advertisement is a capability that enables LDMSD automatically add | |||
There was a problem hiding this comment.
LDMSD Peer Daemon advertisement is a capability that enables LDMSD to automatically add
tom95858
requested changes
Nov 21, 2024
| @@ -47,7 +47,7 @@ ldmsd_sampler_advertisement - Manual for LDMSD Sampler Advertisement | |||
|
|
|||
| .SH DESCRIPTION | |||
|
|
|||
| LDMSD Sampler Discovery is a capability that enables LDMSD automatically add | |||
| LDMSD Sampler Advertisement is a capability that enables LDMSD automatically add | |||
| producers that its hostname matches a given regular expression. The feature | |||
There was a problem hiding this comment.
producers for advertisers whose hostname matches a regular expression.
| @@ -47,7 +47,7 @@ ldmsd_sampler_advertisement - Manual for LDMSD Sampler Advertisement | |||
|
|
|||
| .SH DESCRIPTION | |||
|
|
|||
| LDMSD Sampler Discovery is a capability that enables LDMSD automatically add | |||
| LDMSD Sampler Advertisement is a capability that enables LDMSD automatically add | |||
| producers that its hostname matches a given regular expression. The feature | |||
| eliminates the need for manual configuration of sampler hostname in the | |||
There was a problem hiding this comment.
reduces the need for the manual configuration of producers in configuration files
Yes, I agree. |
nichamon
force-pushed
the
fix-adv-man-typo
branch
from
8678076
to
ebe98f0
Compare
nichamon
changed the title
The patch renames Sampler Advertisement to Peer Daemon Advertisement. It also updates and fixes typos in the man page.
nichamon
force-pushed
the
fix-adv-man-typo
branch
from
ebe98f0
to
20e7cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.