Fix ovis_event thrstat calculation #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `__thrstat_wait_start()` was called, the caller was going into INACTIVE state from ACTIVE state. Hence, the duration from `wait_end` to `now` was the active time and should be added to `proc_tot`. Likewise, when `__thrstat_wait_end()` was called, the caller just woke up. Hence, the duration from `wait_start` to `now` was an INACTIVE time and should be added to `wait_tot`.
nichamon
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
__thrstat_wait_start()was called, the caller was going into INACTIVE state from ACTIVE state. Hence, the duration fromwait_endtonowwas the active time and should be added toproc_tot.Likewise, when
__thrstat_wait_end()was called, the caller just woke up. Hence, the duration fromwait_starttonowwas an INACTIVE time and should be added towait_tot.