test: add DefaultCollection.parse_init_arguments tests (#20)

ovsds · Feb 20, 2024 · 63de282 · 63de282
1 parent 3f6e05f
commit 63de282
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/secret_transfer/default/collection/default.py b/secret_transfer/default/collection/default.py
@@ -21,6 +21,7 @@ def from_init_arguments(cls, data: core.InitArgumentType) -> typing_extensions.S
         source = data.get("source")
         if source is None:
             raise ValueError("Should have a source.")
+
         if not isinstance(source, protocol.SourceProtocol):
             raise ValueError("Should have a source of type SourceProtocol.")
 

diff --git a/tests/unit/default/collection/test_default.py b/tests/unit/default/collection/test_default.py
@@ -39,14 +39,45 @@ def test_parse_init_arguments():
     }
 
 
-def test_parse_init_arguments_invalid():
-    test_source = test_utils.MagicMock(spec=protocol.SourceProtocol)
+def test_parse_init_arguments_not_a_mapping():
+    with pytest.raises(secret_transfer.DefaultCollection.ValidationError):
+        secret_transfer.DefaultCollection.parse_init_arguments(
+            **{
+                TEST_KEY: "not_a_mapping",
+            }
+        )
+
+
+def test_parse_init_arguments_no_source():
+    with pytest.raises(secret_transfer.DefaultCollection.ValidationError):
+        secret_transfer.DefaultCollection.parse_init_arguments(
+            **{
+                TEST_KEY: {
+                    "key": TEST_SOURCE_KEY,
+                },
+            }
+        )
+
+
+def test_parse_init_arguments_no_source_of_type():
+    with pytest.raises(secret_transfer.DefaultCollection.ValidationError):
+        secret_transfer.DefaultCollection.parse_init_arguments(
+            **{
+                TEST_KEY: {
+                    "source": "not_a_source",
+                    "key": TEST_SOURCE_KEY,
+                },
+            }
+        )
+
 
+def test_parse_init_arguments_no_key_of_type():
     with pytest.raises(secret_transfer.DefaultCollection.ValidationError):
         secret_transfer.DefaultCollection.parse_init_arguments(
             **{
                 TEST_KEY: {
-                    "source1": test_source,
+                    "source": test_utils.MagicMock(spec=protocol.SourceProtocol),
+                    "key": 123,
                 },
             }
         )