Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add blintdb to blint #124

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Feat: Add blintdb to blint #124

wants to merge 25 commits into from

Conversation

aryan-rajoria
Copy link
Collaborator

@aryan-rajoria aryan-rajoria commented Dec 6, 2024 •
edited
Loading

Adds blint.db support for blint.
Changes:

  1. Adds a db.py file.
  2. Adds blintdb specific arguments in cli.py.
  3. Adds try except error handling to Archive error encountered during opening Archive.
  4. Adds oras to download the database

@aryan-rajoria aryan-rajoria changed the title Feat: Add blintdb to blin Feat: Add blintdb to blint Dec 9, 2024
@aryan-rajoria
fix issue with unexpected ArchiveError
12bb195 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add blintdb download and implement step
d1fb9f7 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add database functions
7487c99 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
final changes
e21d5ed 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
improve blintdb performance
e3f5c85 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
improve blintdb performance, testing
3a7ab15 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
final updates sub 1 min processing
6a7a910 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix
0207c7b 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix incomplete
7b59c3a 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix also remove max_workers
37f272a 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
cleanup
b1e72e4 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria aryan-rajoria marked this pull request as ready for review December 18, 2024 15:35
@aryan-rajoria
update poetry lock
ab0c33f 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
code cleanup
be16b65 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix
6a527e3 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
fix Namespace issue
8e3d560 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
Copy link
Collaborator Author

Please suggest if default behavior of keeping use_blintdb being False and blintdb_home being $HOME/blintdb all right?

@aryan-rajoria aryan-rajoria requested a review from prabhu December 19, 2024 12:01
cerrussell
cerrussell requested changes Dec 19, 2024
View reviewed changes
blint/cli.py Outdated Show resolved Hide resolved
blint/config.py Outdated Show resolved Hide resolved
blint/lib/utils.py Outdated Show resolved Hide resolved
blint/cli.py Show resolved Hide resolved
blint/lib/utils.py Outdated Show resolved Hide resolved
blint/cli.py Show resolved Hide resolved
@aryan-rajoria
add suggested changes
ea9beca 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add capital debug
c2d8c36 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add connection fail exception handling
739b81e 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
add tests for blint
d0a2986 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
update test_get_bid_using_ename_batch
44023ee 
Signed-off-by: Aryan Rajoria <[email protected]>
cerrussell
cerrussell reviewed Dec 28, 2024
View reviewed changes
blint/lib/utils.py Outdated Show resolved Hide resolved
cerrussell
cerrussell reviewed Dec 28, 2024
View reviewed changes
blint/lib/utils.py Outdated Show resolved Hide resolved
cerrussell
cerrussell reviewed Dec 28, 2024
View reviewed changes
blint/lib/utils.py Outdated Show resolved Hide resolved
cerrussell
cerrussell reviewed Dec 28, 2024
View reviewed changes
blint/lib/utils.py Outdated Show resolved Hide resolved
@aryan-rajoria
add suggested changes
f7cac23 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
move tests
39314db 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
remove debugging statement
22a7ab1 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
blintdb set to true
df3d058 
Signed-off-by: Aryan Rajoria <[email protected]>
@aryan-rajoria
blintdb refresh should be in list
1a33d0f 
Signed-off-by: Aryan Rajoria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cerrussell cerrussell cerrussell requested changes

@prabhu prabhu Awaiting requested review from prabhu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryan-rajoria @cerrussell