Put the ModSecurity interception logic onto separated threads #289
+664
−411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to describe my patch to fix #227 and it is by no means a complete patch ready for merge.
The patch contains several unrelated changes, namely:
dd
tongx_log_error
to accomodate my own debugging needngx_http_modsecurity_pcre_malloc_init
andngx_http_modsecurity_pcre_malloc_done
. They are not used in my configuration where PCRE2 is used, and it looks suspicious for SEGVs so I commented them out as a precaution.NGX_OK
in logging handler? Changed toNGX_DECLINED
.Not yet implemented:
NGX_THREADS
guard for Nginx setup without threading support.Currently it passes all test suites and performs well in production.
Benchmarking is welcomed.