Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added initial Github CI workflow #318

Merged
merged 7 commits into from
Apr 16, 2024
Merged

feat: added initial Github CI workflow #318

merged 7 commits into from
Apr 16, 2024

Conversation

airween
Copy link
Member

@airween airween commented Apr 16, 2024

Added .github/workflow/ci.yml and necessary files with a complex test workflow for each PR.

A brief summary about how does it work:

  • set up dependencies (required packages)
  • install latest ModSecurity3 release
  • get ModSecurity-nginx source
  • get latest Nginx soure
  • build Nginx with ModSecurity module
  • start Nginx with ModSecurity
  • there are two virtual hosts
  • there is only one rule
  • run a valid request (expected code is 200) and an attack (expected code is 403) against both vhosts

@airween airween mentioned this pull request Apr 16, 2024
Closed
@airween airween self-assigned this Apr 16, 2024
theseion
theseion suggested changes Apr 16, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@airween airween requested a review from theseion April 16, 2024 19:54
@airween
Copy link
Member Author

airween commented Apr 16, 2024

Many-many thanks for @theseion for your big help!

@airween airween merged commit 61425ed into owasp-modsecurity:master Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees

@airween airween

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@airween @theseion