Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the minimum security protocol version for SecRemoteRules #3041

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Set the minimum security protocol version for SecRemoteRules #3041

merged 1 commit into from
Jan 30, 2024

Conversation

airween
Copy link
Member

@airween airween commented Jan 27, 2024

See Sonarcloud report - this PR fixes it in v3.

@airween airween requested review from dune73 and marcstern January 27, 2024 16:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

@fzipi
Copy link
Contributor

fzipi commented Jan 27, 2024

Can you try to follow https://www.conventionalcommits.org/en/v1.0.0/ for PR titles?

fzipi
fzipi approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcstern marcstern merged commit a859574 into owasp-modsecurity:v3/master Jan 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

@fzipi fzipi fzipi approved these changes

@dune73 dune73 Awaiting requested review from dune73

@marcstern marcstern Awaiting requested review from marcstern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@airween @fzipi @theseion @marcstern