Clean up 'return' never will be executed. #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirkoDziadzka
approved these changes
Feb 26, 2024
…, as pthread_exit() does not return.
airween
requested changes
Feb 27, 2024
examples/reading_logs_via_rule_message/reading_logs_via_rule_message.h
Outdated
Show resolved
Hide resolved
|
airween
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference: https://sonarcloud.io/project/issues?open=AY1CfKFNrsSpWCKX0w9c&id=owasp-modsecurity_ModSecurity
There are three occurrences of this issue. I deleted pthread_exit(NULL) calls, because these execution points are not in
pthread execution scope. In process_request() I kept pthread_exit(NULL) and deleted return(NULL), because here we are
in pthread execution context.
(FYI: 11.5 Thread Termination in Advanced Programming in the UNIX® Environment, Third Edition)