Additional sqlHexDecode transformation tests & removal of missing phpArgsNames transformation #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These were added to test changes in owasp-modsecurity/ModSecurity#3231
…uded in libModSecurity v3
- Support for this transformation was introduced in the context of
owasp-modsecurity/ModSecurity#2387, but it's not currently in the
library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlHexDecodetransformation implementation in libModSecurity v3 was updated in the context of Remove unnecessary heap allocated copies in Transformation actions ModSecurity#3231 and new tests were created to further validate its behaviour.phpArgsNamestransformation was implemented in the context of Add new transformation call phpArgsNames ModSecurity#2387. However, it's not currently in the libModSecurity v3 codebase, so this PR removes the associated tests (because if you checkout the latest version of this repository, it triggers failed tests for a feature that is not available).