Merge pull request #441 from owasp-noir:improve-banner

Refactor config initializer and options parser

src/config_initializer.cr

@@ -25,9 +25,7 @@ class ConfigInitializer
 
     # Create the config file if it doesn't exist
     File.write(@config_file, generate_config_file) unless File.exists?(@config_file)
-  rescue e : Exception
-    puts "Failed to create config directory or file: #{e.message}"
-    puts "Using default config."
+  rescue
   end
 
   def read_config
@@ -71,9 +69,6 @@ class ConfigInitializer
       final_options = default_options.merge(symbolized_hash) { |_, _, new_val| new_val }
       final_options
     rescue e : Exception
-      puts "Failed to read config file: #{e.message}"
-      puts "Using default config."
-
       default_options
     end
   end

src/noir.cr

@@ -9,9 +9,6 @@ module Noir
   VERSION = "0.18.0"
 end
 
-# Print banner
-banner()
-
 # Run options parser
 noir_options = run_options_parser()
 
@@ -57,6 +54,7 @@ if noir_options["exclude_codes"] != ""
 end
 
 # Run Noir
+banner()
 app = NoirRunner.new noir_options
 start_time = Time.monotonic
 

src/options.cr

@@ -133,13 +133,10 @@ def run_options_parser
       case var
       when "zsh"
         puts generate_zsh_completion_script
-        STDERR.puts "\n> Instructions: Copy the content above and save it in the zsh-completion directory as _noir".colorize(:yellow)
       when "bash"
         puts generate_bash_completion_script
-        STDERR.puts "\n> Instructions: Copy the content above and save it in the .bashrc file as noir.".colorize(:yellow)
       when "fish"
         puts generate_fish_completion_script
-        STDERR.puts "\n> Instructions: Copy the content above and save it in the fish-completion directory as noir.fish".colorize(:yellow)
       else
         puts "ERROR: Invalid completion type.".colorize(:yellow)
         puts "e.g., noir --generate-completion zsh"
@@ -164,6 +161,7 @@ def run_options_parser
     end
     parser.separator "\n  OTHERS:".colorize(:blue)
     parser.on "-h", "--help", "Show help" do
+      banner()
       puts parser
       puts ""
       puts "EXAMPLES:"