Fix TermTaxonomy attributes sanitizing to not remove translation tags #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen2345
approved these changes
Aug 23, 2024
…>= 7.1 is ignoring nils by default)
texpert
force-pushed
the
dont-sanitize-translation-tags
branch
from
351a390 to
327b487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitization of the
TermTaxonomyattributes were surprizingly removing translation tags.So, instead of a
<!--:en-->Vineyards<!--:--><!--:ru-->Виноградники<!--:--><!--:md-->Podgorii<!--:-->attr value, theVineyardsВиноградникиPodgoriiwas stored into the DB.This PR fixes the issue, hiding the translation tags before sanitizing them, and restoring them afterwards.