Skip to content

Commit

Permalink
Remove unnecessary TO-DO
Browse files Browse the repository at this point in the history
  • Loading branch information
pabloarosado committed May 13, 2024
1 parent b43a7f7 commit d7108e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions etl/steps/data/garden/noaa_ncei/2024-05-09/natural_hazards.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,11 @@ def run(dest_dir: str) -> None:
.assign(**{"type": table_name})
)

# TODO: Usually "deathstotal" is more often informed than "deaths", but there are also cases where there is
# NOTE: Usually "deathstotal" is more often informed than "deaths", but there are also cases where there is
# "deaths" but not "deathstotal". Since "deathstotal" includes all deaths (including secondary ones), it would make
# sense to fill empty "deathstotal" with "deaths".
# However, note that there are events where "deaths" > "deathstotal", which should not happen.
# These are probably data issues. Contact the source about it.
# These are probably data issues. I contacted the data provider to ask about it.

# Merge all tables.
tb = pr.concat(list(tables.values()), ignore_index=True)
Expand Down

0 comments on commit d7108e4

Please sign in to comment.