Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export step fails to create new branch #3584

Closed
pabloarosado opened this issue Nov 21, 2024 · 1 comment
Closed

Export step fails to create new branch #3584

pabloarosado opened this issue Nov 21, 2024 · 1 comment

Comments

@pabloarosado
Copy link
Contributor

I was trying to execute the export://github/co2_data/latest/owid_co2 step, by running:

CO2_BRANCH=update-gcb-data etlr github/co2_data --export

However, I encountered a few issues:

  • OWIDBOT_ACCESS_TOKEN needed to be defined in .env. This was easy to fix, but I'm wondering if this was necessary. I suppose it should rather be using our GITHUB_TOKEN.
  • I expected it would create a new branch, but instead it failed because the branch was not found. So I manually created the branch, rerun the export step, and then it worked.

Ideally, this step should:

  • Not require the CO2_BRANCH variable. Instead, it would create a branch with the same name as the current ETL branch (and, if it already exists, it should fail, for safety).
  • Create a branch and a PR.
@Marigold
Copy link
Collaborator

Marigold commented Dec 2, 2024

Fixed by #3605

@Marigold Marigold closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants